No, the RCAF had no trouble attracting qualified applicants. What the RCAF has is difficulty getting those applicants through the training system fast enough. Fixing this problem is out of the RCAF’s hands, and has been ever since pilot training was contracted out.
As for your other points, they are mostly wrong.
-Most of the places the RCAF posts you have some good things to offer, you just need to be open minded.
-If you are flexible and smart you can dodge a desk. If you do get stuck on a desk you can go fly civi in your off time (Instruct, drop skydivers, do helo tours)
-For most pilots, time away from home is comparable to that of an airline
-It’s not the Marines; you aren’t going to be standing at attention yelling ‘Yes Sir, No Sir.” All day. It’s not uncommon to be on a first name basis with everybody except the CO.
The things that do tend to wear people down are the geographical mobility (moving every 3 years or so). This is not all that different from someone starting out in civi flying, and if you play your cards right, you can attain geographic stability after a few postings. The other thing that wears people down are the ancillary requirements that come with being an officer; fitness tests, secondary duties, dealing with government bureaucracy.